This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

config/ia64/crtbegin.asm bug fix for glibc


The HAVE_GAS_HIDDEN macro isn't defined because we don't include the
auto-host.h file here.  Also, there is another problem that HAVE_GAS_HIDDEN
doesn't get correctly defined by configure in all cases.  The configure
tests fail if using a "Cygnus" one-source tree.  This is because the GNU as
binary does not exist at the time we configure gcc, and hence all the tests
that attempt to run the assembler fail.

This asm file is only used by gas, and all versions of gas that support
IA-64 also support .hidden, so we can solve both problems by not bothering
to test the macro.
	
If in the future someone wants to make this file work with a non-GNU
assembler, then we can revisit the issue.
	
This problem showed up as a glibc make check failure.

2000-09-19  Jim Wilson  <wilson@cygnus.com>

	* config/ia64/crtbegin.asm (__dso_handle): Delete use of
	HAVE_GAS_HIDDEN macro.

Index: crtbegin.asm
===================================================================
RCS file: /cvs/cvsfiles/devo/gcc/config/ia64/crtbegin.asm,v
retrieving revision 1.10
diff -p -r1.10 crtbegin.asm
*** crtbegin.asm	2000/08/27 16:11:59	1.10
--- crtbegin.asm	2000/09/20 00:53:29
*************** __dso_handle:
*** 54,62 ****
  __dso_handle:
  	data8	0
  #endif
- #ifdef HAVE_GAS_HIDDEN
  	.hidden __dso_handle#
- #endif
  
  	/* The frame object.  */
  	/* ??? How can we rationally keep this size correct?  */
--- 54,60 ----

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]