This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA:] Remove extraneous spacing from directives in config/elfos.h


Hi Hans-Peter,

: If your ELF assembler is based on GAS, and you change ASM_FILE_START
: to emit #NO_APP (not using the default from elfos.h), gas will
: complain about extraneous spacing.

Does it really ?  Can you remember the exact wording of the error
message ?

: ! #define CONST_SECTION_ASM_OP	"\t.section\t.rodata"
:   
: --- 254,260 ----
:   
: ! #define CONST_SECTION_ASM_OP	".section\t.rodata"

These tabs are all deliberately inserted.  Some assemblers, including
some GAS versions insist that only labels and comments can start in
the first column, and that all other directives, including
instructions and pseudo ops, should be indented.

: Ok to commit?

I would advise against this.

Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]