This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: next arm gcc problem


Hi Phil,

: I see it now.  I think this particular instance was introduced with the 
: merged ARM/Thumb backend.  I've appended a patch below.
: 
: Nick: it's no good for the compiler to define `arm' and `thumb' by default - 
: this causes all sorts of unexpected lossage when the names collide with stuff 
: in user code.  (I'm not terribly happy about having `-Dunix' and `-Dlinux' in 
: there either, but historically this doesn't seem to have caused so many 
: problems.)

Fair enough.  I put them in (or rather left them in) because they were
defined in the original arm and thumb ports, and I did not want to
break anybody's code by leaving them out.  But I quite agree that they
shouldn't really be defined, and if they are causing things to break,
then by all means we should remove them.

: 2000-09-10  Philip Blundell  <philb@gnu.org>
: 
: 	* config/arm/arm.h (CPP_ISA_SPEC): Don't define `arm' or `thumb'.
: 	* config/arm/linux-elf.h (CPP_PREDEFINES): Don't define `__arm__'.

I think that last line in the ChangeLog should be:

               "Don't define '__arm__' in thumb mode"

Other than that, I approve of this patch.

Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]