This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch for builtin fputs (first stdio opt ready for install)



  In message <200009072106.RAA08081@caip.rutgers.edu>you write:
  >  > From: Jason Merrill <jason@redhat.com>
  >  > 
  >  > You could save a pointer to the _DECL for __builtin_fputc in
  >  > c_common_nodes_and_builtins.
  >  > Jason
  > 
  > 
  > Here's what I came up with.  Bootstrapped on solaris2.7, no testsuite
  > regressions.  Okay to install?
  > 
  > 
  > 
  > 2000-09-06  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
  > 
  > 	* builtins.c (built_in_decls): New array.
  > 	(expand_builtin_fputs): New function.
  > 	(expand_builtin): Handle BUILT_IN_FPUTC and BUILT_IN_FPUTS.
  > 
  > 	* builtins.def (BUILT_IN_FPUTC, BUILT_IN_FPUTS): New members.
  > 
  > 	* c-common.c (c_common_nodes_and_builtins): Handle fputc/fputs.
  > 
  > 	* tree.h (built_in_decls): New array.
I might have missed something -- you appear to be registering a builtin
fputc too, but no expander for it.  What's the point behind that?

I also think you should kill the debugging #ifdefs.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]