This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patches not reviewed or integrated
- To: Stephane Carrez <Stephane dot Carrez at worldnet dot fr>
- Subject: Re: Patches not reviewed or integrated
- From: Geoff Keating <geoffk at cygnus dot com>
- Date: 06 Sep 2000 14:47:51 -0700
- CC: gcc-patches at gcc dot gnu dot org
- References: <39B6CBF1.6B4DDC59@worldnet.fr>
Stephane Carrez <Stephane.Carrez@worldnet.fr> writes:
> Hi!
>
> Any news about the review/integration of the following patches (68hc11 port)?
>
> [PATCH]: Unsigned -> float conversion for fp-bit.c
> http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00290.html
This patch is OK.
> [PATCH]: Dump rtl in assembly
> http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00289.html
This patch needs to be documented. You need to update
invoke.texi.
> [PATCH]: libgcc2.h fix to build DI mode operations
> http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00288.html
This patch seems OK.
> [PATCH]: Update gcc.1 man page for 68HCx port.
> http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00274.html
This patch is OK, but see my comment below about the texinfo
documentation.
> [PATCH]: Recognize 68HC11 & 68HC12 target in gcc
> http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00273.html
This patch is OK.
> [PATCH]: 68HC11 & 68HC12 port (gcc/config/m68hc11)
> http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00272.html
This patch is missing documentation. You need to go through the Info
documentation and add
- the description of -m options your port uses
- the special constraints your port has
Also, the very last line of the patch has
+#define inhibit_libc
which is not the right way to do whatever it is you want.
Otherwise, it looks OK, and could be committed as-is. You should add
yourself to the MAINTAINERS file as the maintainer of the new port.
> Thanks for taking some time to have a look at them,
Do you have a copyright assignment on file? Do you have commit access
to the tree?
--
- Geoffrey Keating <geoffk@cygnus.com>