This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: gcc intrinsics for am33 parallel integer arithmetic


Matthew Hiller wrote:
> 
I like the patch.  This will be great for the am33.  Couple of things
you might want to think about.

[lots of snipping]

There are a lot of cases like this in the patch:

+ void
+ am33_init_builtins ()
+ {
+   if (TARGET_AM33)

Perhaps it would be better if there was a general mn10300_init_builtins
func that checked for TARGET_AM33 and init based on the specific
processor variant?

I don't know if this sort of thing is correct in general.  Someone else
may be able to comment more.

[lots more snipping]

Could do with some comments too.  Stuff like "Implements AM33 specific
DSP instructions.",  etc?  Especially at the top of dsp.h.

-eric

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]