This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PIC support for SH
- To: Alexandre Oliva <aoliva at redhat dot com>
- Subject: Re: [PATCH] PIC support for SH
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Thu, 31 Aug 2000 10:19:46 -0600
- cc: kaz Kojima <kkojima at rr dot iij4u dot or dot jp>, gcc-patches at gcc dot gnu dot org
- Reply-To: law at cygnus dot com
In message <or66ohil7i.fsf@guarana.lsd.ic.unicamp.br>you write:
> --=-=-=
>
> On Aug 29, 2000, kaz Kojima <kkojima@rr.iij4u.or.jp> wrote:
>
> > Here's a patch to support -fpic option for Hitach SH processors. The
> > patch consists of two parts, SH specific changes and emit-rtl.c
> > change.
>
> Here's a patch that brings from the Red Hat internal sources all the
> changes for -fPIC support on sh-elf. I guess I could just go ahead
> and install them, since Jeff Law had already approved them all, but
> I'll wait for explicit approval for the GCC tree. Ok to install?
Re-reviewed and re-approved for the net tree this time :-)
> +#if 0
> /* Arrange to call __main, rather than using crtbegin.o and crtend.o
> and relying on .init and .fini being executed at appropriate times. */
> #undef INIT_SECTION_ASM_OP
> #undef FINI_SECTION_ASM_OP
> #undef STARTFILE_SPEC
> #undef ENDFILE_SPEC
> +#endif
Instead of using an #if 0 block, delete the code.
If you want to leave a comment behind, do so, but please let's avoid
having lots of code that is either commented out or #if 0'd out.
I believe the copyright date on the new files crt files should just be
2000.
Also can you make sure the exception clause in those new crt files
matches the one currently in libgcc2.c? They probably do, but
let's be 100% sure ;-)
jeff