This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: SH: cmpeqdi splitter messes up the CFG


On Aug 29, 2000, Richard Henderson <rth@cygnus.com> wrote:

> On Tue, Aug 29, 2000 at 06:02:52AM -0300, Alexandre Oliva wrote:
>> A define_split shouldn't be emitting jumps and labels.  It messes up
>> the CFG and the BB structure too late in the compilation process.

> Err.. the split pass run after reload and before flow2 should
> be able to do just this.  Is it not running then?

The insn is only being split by the machine-specific reorg pass.  It's
too late by then.  JUMP_LABEL isn't set, and, since
INSN_ADDRESSES_SET_P already holds, insn_current_reference_address()
crashes when dereferencing the JUMP_LABEL.

In any case, I think the approach taken by my patch is simpler and
superior.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]