This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to fix noncompile/label-lineno-1.c
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Subject: Re: Patch to fix noncompile/label-lineno-1.c
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Tue, 29 Aug 2000 10:49:57 -0600
- cc: gcc-patches at gcc dot gnu dot org
- Reply-To: law at cygnus dot com
In message <200008242039.QAA03128@caip.rutgers.edu>you write:
> This patch fixes the noncompile/label-lineno-1.c testsuite failures.
>
> It seems that maybe_attribute in c-parse.in messes up the line
> numbering in certain cases so I resorted to using save_filename &
> save_lineno as is done elsewhere in the file to combat this problem.
>
> I'm not a grammer expert, so I wasn't sure where in the line they
> should go, e.g. before `identifier', between `identifier' and the
> colon, or after the colon where I put them. (Or maybe it doesn't
> matter?)
>
> Anyway, bootstrapped on i686-pc-linux-gnu. Okay to install?
>
> --Kaveh
>
>
>
> 2000-08-24 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
>
> * c-decl.c (define_label): Call warning_with_file_and_line and
> error_with_file_and_line instead of plain warning or error.
>
> * c-parse.in (label): Use save_filename/save_lineno to ensure
> correct values for calls to define_label.
Approved.
jeff