This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: Prune unused DECL_STMTs from saved tree structure
- To: law at cygnus dot com
- Subject: Re: Patch: Prune unused DECL_STMTs from saved tree structure
- From: Mark Mitchell <mark at codesourcery dot com>
- Date: Tue, 29 Aug 2000 09:46:35 -0700
- Cc: zack at wolery dot cumb dot org, gcc-patches at gcc dot gnu dot org
- Organization: CodeSourcery, LLC
- References: <20000829093335W.mitchell@codesourcery.com><6723.967567005@upchuck>
>>>>> "Jeffrey" == Jeffrey A Law <law@cygnus.com> writes:
Jeffrey> In message
Jeffrey> <20000829093335W.mitchell@codesourcery.com>you write:
>> > * c-semantics.c (remove_unused_decls, >
>> remove_unused_decls_from_block): New functions. > *
>> c-common.h: Prototype remove_unused_decls. > cp: > *
>> semantics.c (finish_stmt_tree): Call remove_unused_decls. This
>> is fine. Please install this patch.
>>
>> Oh, dear. And here I was about to say that we should be using
>> walk_tree for this instead.
Jeffrey> OK. Then let's have it use walk_tree. I don't think
Jeffrey> Zack has checked in the change yet (I approved it just a
Jeffrey> few minutes ago).
Jeffrey> Presumably walk_tree doesn't look at any nodes we don't
Jeffrey> want to look at in this code? I believe there was some
Jeffrey> question about following the TREE_CHAINs in some of the
Jeffrey> nodes.
Good question. walk_tree is pretty flexible -- you can give it hints
about how to walk -- but perhaps it is not worth the bother. Zack,
why don't you take a quick look, and if you can't make it work, use
your original patch. We can always switch it later.
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com