This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: fix a couple of bounds violations


On Sun, Aug 27, 2000 at 11:08:01AM -0700, Greg McGary wrote:
> Zack Weinberg <zack@wolery.cumb.org> writes:
> 
> > On Sun, Aug 27, 2000 at 02:27:51PM +0100, Neil Booth wrote:
> > > Greg McGary wrote:-
> > > 
> > > > -	      if (namebuf[-1] == '\\')
> > > > +	      if (namebuf > list->namebuf && namebuf[-1] == '\\')
> > > 
> > > This bit's my bug and is the correct fix, but I can't authorise you to
> > > commit it <g>.  It probably comes under the "obvious" rule, though.
> > 
> > I'll approve it, but do you have a test case?
> 
> Line 33 of gcc/testsuite/gcc.dg/20000724-1.c, which is this:
> 
> ----------------------------------------
> asm ("
> ----------------------------------------
> 
> while parsing the quoted string.

Ah, okay, then we don't need a new one.  Please apply the patch.

zw

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]