This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [PATCH] Fix i386 PIC breakage

To: Jan Hubicka <jh at suse dot cz>
Subject: Re: [PATCH] Fix i386 PIC breakage
From: Jakub Jelinek <jakub at redhat dot com>
Date: Thu, 13 Jul 2000 15:17:16 +0200
Cc: rth at cygnus dot com, gcc-patches at gcc dot gnu dot org
References: <20000713114819.S17419@sunsite.ms.mff.cuni.cz> <20000713150333.A6613@atrey.karlin.mff.cuni.cz>
Reply-To: Jakub Jelinek <jakub at redhat dot com>

On Thu, Jul 13, 2000 at 03:03:33PM +0200, Jan Hubicka wrote:
> > Hi!
> > 
> > Sat Jul  8 01:38:25 MET DST 2000  Jan Hubicka  <jh@suse.cz>
> > 
> > 	* i386.md (call_pop, call, call_value_pop): Do not set
> > 	current_function_uses_pic_offset_table for calls to static
> > 	functions or indirect calls.
> > 
> > broke PIC support on i386.
> Oops... silly cut&paste bug. I wonder why it didn't prevented glibc
> from compile for me....
> 
> Note that you need to also fix the fourth copy in call_value pattern.

That's already done in the patch, there are 4 hunks. You did not list
call_value in your ChangeLog entry though :)

	Jakub

References:
- [PATCH] Fix i386 PIC breakage
  - From: Jakub Jelinek
- Re: [PATCH] Fix i386 PIC breakage
  - From: Jan Hubicka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]