Re: RESEND: PATCH: Factor common text out of the specs

[Toon Moene <toon at moene dot indiv dot nluug dot nl>]

Zack Weinberg wrote:

> I'm resending this patch, which has received zero discussion in the
> month since it was posted.  It factors the long runs of common text
> out of the lang-specs files into named specs.  For the original patch
> and a more detailed explanation, see
> http://gcc.gnu.org/ml/gcc-patches/2000-05/msg01342.html.

I'm very sorry to have to say that this patch cannot get my approval.

Consider the following Fortran source:

      subroutine aap(a, n)
      dimension a(n)
      do 10 i = 1, n
         a(i) = i
 10   continue
      print *, a(1)
      end

When compiled as `a.f' nothing strange happens.

Now copy the a.f to a.F (which means that the preprocessor is run on it
before the Fortran Frontend gets a chance to parse the source):

a.F: In subroutine `aap':
a.F:5: 
    10 continue
       ^
Non-numeric character at (^) in label field [info -f g77 M LEX]
a.F:3: 
         do 10 i = 1, n
         1
a.F:7: (continued):
         end
         2
Statement at (2) invalid in context established by statement at (1)
a.F:3: 
         do 10 i = 1, n
         ^
End of source file before end of block started at (^)

Retry, do not pass Go ...

-- 
Toon Moene - mailto:toon@moene.indiv.nluug.nl - phoneto: +31 346 214290
Saturnushof 14, 3738 XG  Maartensdijk, The Netherlands
GNU Fortran 77: http://gcc.gnu.org/onlinedocs/g77_news.html
GNU Fortran 95: http://g95.sourceforge.net/ (under construction)