This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

[PATCH] - Fix bogus dependency in Makefile.in


Jason, you're responsible for reintroducing that bug.

This is a mistake I had fixed earlier.
You can't depend on $(LANGUAGES), this is NOT a real dependency.
Depending on $(LANGUAGES) only ensures that the target is always,
ALWAYS rebuilt.

For instance, for libgcc.a, this means the library is built ONCE
for make bootstrap. And a second time for make install.

Considering that builds can happen as joe-average user, and installs
can happen as root, you end up with a libgcc.a that's built by root.

Ouch.

I'm going to write a real patch that gives you the possibility to
depend on `languages' (that's not hard), but in the mean-time, consider
applying this.

Sun Jul  2 18:13:51 CEST 2000	Marc Espie <espie@openbsd.org>

	* Makefile.in (LIBGCC_DEPS):  Remove bogus dependency.

Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/egcs/gcc/Makefile.in,v
retrieving revision 1.473
diff -c -r1.473 Makefile.in
*** Makefile.in	2000/07/02 05:22:58	1.473
--- Makefile.in	2000/07/02 16:13:28
***************
*** 962,968 ****
  	mv tmp-libgcc.mk libgcc.mk
  
  # All the things that might cause us to want to recompile bits of libgcc.
! LIBGCC_DEPS = $(GCC_PASSES) $(LANGUAGES) stmp-int-hdrs $(STMP_FIXPROTO) \
  	libgcc.mk $(srcdir)/libgcc1.c $(srcdir)/libgcc2.c $(CONFIG_H) \
  	$(MACHMODE_H) longlong.h frame.h gbl-ctors.h config.status \
  	stmp-int-hdrs tsystem.h $(FPBIT) $(DPBIT) $(LIB2ADD)
--- 962,968 ----
  	mv tmp-libgcc.mk libgcc.mk
  
  # All the things that might cause us to want to recompile bits of libgcc.
! LIBGCC_DEPS = $(GCC_PASSES) stmp-int-hdrs $(STMP_FIXPROTO) \
  	libgcc.mk $(srcdir)/libgcc1.c $(srcdir)/libgcc2.c $(CONFIG_H) \
  	$(MACHMODE_H) longlong.h frame.h gbl-ctors.h config.status \
  	stmp-int-hdrs tsystem.h $(FPBIT) $(DPBIT) $(LIB2ADD)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]