This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: One more test-suite rearrangement


 > From: Zack Weinberg <zack@wolery.cumb.org>
 > 
 > This patch moves gcc.c-torture/noncompile over to the dg directory.
 > Tests for error reporting are a much better match to the dg framework;
 > we can eliminate the fragile list regexps in noncompile.exp entirely.
 > Also, since dg doesn't iterate over optimization options (which is
 > useless when you're testing error reports) it runs through this set of
 > tests about five times faster.
 > zw

Moving preprocessor tests is fine, but IIRC some of the noncompile
tests caused cc1 crashes on Irix6 but only on certain optimization
and/or debug levels.  So moving tests to dg loses this sanity check.

I've seen many tests which were introduced because a bug triggered at
a particular opt level, but months or years later trigger again at
some other level due to some unrelated breakage.  Less opt cycle
checking reduces the quality of the compiler.

Except for cpp testing, IMHO, the fact that dg does not cycle opt
levels is a very bad thing and we should not put more cc1 tests there
until this is fixed.  Even if the checks just look for error messages,
the underlying code always has the potential to crash cc1 with some
-O# flag.

		--Kaveh
--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Qwest Internet Solutions

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]