This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: g++ testsuite


In article <20000627134131J.mitchell@codesourcery.com> you write:

>This line:
>
>!     set odir_v3 [lookfor_file ${gccpath} libstdc++-v3]
>
>sets odir_v3 to a non-empty file even when libstdc++-v3 isn't being
>used because lookfor_file looks up far enough that it finds the
>libstdc++-v3 in the source directory.

Oops!  I only thought about and tested the case where srcdir !=
objdir.  I will also confess that I didn't know [lookfor_file ...]
hunted up the directory hierarchy.  In retrospect, I can see how this
would break when one configures and builds in the same directory as
the source.

>Fixed with this patch, which hopefully keeps V3 tests working as
>well.

Actually, I suspect that odir_v2 will be set to a non-empty file when
v3 was configured for the reason you outline above whenever srcdir ==
objdir.

Open question to dejagnu experts: Is there any way for the dejagnu
script to directly check which version of the library is configured
without looking for a directory?  Or, is there a dejagnu command, like
[lookfor_file ...], that only checks whether the *exact* match exists
without hunting up the tree?  May I use this dejagnu code directly:

set odir_v3 ""
if [file exists $gccpath/libstdc++-v3] { set odir_v3 $gccpath/libstdc++-v3 }

in place of:

set odir_v3 [lookfor_file ${gccpath} libstdc++-v3]

if I don't want the hunting behavior of lookfor_file?  Is there any
reason why I need the hunting behavior for this particular directory
check?

Regards,
Loren
-- 
Loren J. Rittle
Staff Software Engineer, Distributed Object Technology Lab
Networks and Infrastructure Research Lab (IL02/2240), Motorola Labs
rittle@rsch.comm.mot.com, KeyID: 2048/ADCE34A5, FDC0292446937F2A240BC07D42763672

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]