Re: gcc 2.96: System headers get fixed inadvertently for i386-linux-gnu

["Maciej W. Rozycki" <macro at ds2 dot pg dot gda dot pl>]

On Tue, 13 Jun 2000, Jeffrey A Law wrote:

>   >  A recent change to mkfixinc.sh makes system headers be fixed for the
>   > i[34567]86-*-linux-gnu* target.  The following patch fixes it -- the
>   > target now matches the later *-*-linux-gnu* entry. 
> Actually, we want the headers on linux-gnu to be fixed just like any
> other system.

 Hmm, I suppose I'm missing something here.  Until gcc 2.95 there was a
specific rule for i[34567]86-*-linux-gnu* to work around some glibc 2.0
bugs.  The rule was removed (I'm not sure, why, but I don't care that
much, either) but the empty "case" entry remained.  As a result a default
script is build which creates copies of all glibc and kernel headers for
gcc's private use.

 Other (i.e. non-i[34567]86) linux-gnu* systems are matched by
*-*-linux-gnu* rule which is present later in mkfixinc.sh and is unchanged
for some time and makes fixing be skipped.  Why would i[34567]86 systems
be so different? 

 Anyway, AFAIK fixing is used to repair broken system headers (e.g. 
inappropriate usage of __STDC__).  This is needed for proprietary systems. 
For both glibc and Linux we have full control over preparing propoer
headers -- why would we fix them within gcc (and create private copies
that would unnecessarily cause troubles every time glibc is upgraded) 
instead of fixing original headers instead.  Besides, as of Linux
2.4.0-test1 (and any version since 2.2, at least) and glibc 2.1.90 (or any
2.1.x release), I can't see any troubles with using glibc and Linux
headers directly.  This includes alpha-linux-gnu, i386-linux-gnu and
mipsel-linux-gnu systems I used so far.

 It's possible that my patch is not the best solution but at least it
keeps all linux-gnu* platforms in sync.

  Maciej

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +