This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: boolean_operator fixes for ppc.
- To: Geoff Keating <geoffk at cygnus dot com>
- Subject: Re: boolean_operator fixes for ppc.
- From: David Edelsohn <dje at watson dot ibm dot com>
- Date: Sun, 28 May 2000 21:43:44 -0400
- cc: gcc-patches at gcc dot gnu dot org
>>>>> Geoff Keating writes:
Geoff> This is good, but if you do this it's vitally important that the
Geoff> comment (and optionally the name of the routine) be changed to match
Geoff> the changed behaviour. Perhaps to `reg_or_arith_cint_operand'?
Changing the name of the predicate is fine with me.
Geoff> I guess you could write
Geoff> INTVAL (op) <= 0x7fffffff && INTVAL (op) >= - (HOST_WIDE_INT) 0x80000000u
Geoff> (the tricky bit is forming that constant...)
Yes, there are tricky ways to handle this case, but I also think
that those options make the code less easy to understand. My preference
is to bite the bullet and add the ugly #ifdef's instead of writing more
ugly (IMHO) obfuscated code.
David