Re: cpplib: new lexer touch ups

[Zack Weinberg <zack at wolery dot cumb dot org>]

On Fri, May 05, 2000 at 03:15:33PM +0900, Neil Booth wrote:
> This patch creates a per-token speller into an arbitrary buffer.  This
> is used for the (sample, incomplete) preprocessed file outputter, and
> I imagine will be useful for handling the # and ## preprocessor
> operators.

Yeah, in some of my not-yet-visible work I have this same function.

>  A few functions are renamed and a #define added to ease
> use during the integration stage (for Zack's and my benefit) - these
> changes are temporary.

As long as you're going to do this, please rearrange everything so
that all the structures, #defines, and static prototypes are together
at the top of the file.

> Also, uses Zack's U-macro for what I think he
> intended it for.

Yes, you got it right.

> OK to commit if it bootstraps on i386 linux?

I'd rather see this as two separate patches: one that does the
NEW_LEXER and the function renames, and another with all the
functionality changes.

You may commit a patch that does nothing besides change #if 0 to
#ifdef NEW_LEXER, move all the declarations to the top, and rename
functions such that cpplex.c will compile with NEW_LEXER defined.
Then resend the other patch.

zw