This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix for the C++ testcase submitted today
- To: Jakub Jelinek <jakub at redhat dot com>
- Subject: Re: [PATCH] Fix for the C++ testcase submitted today
- From: Jason Merrill <jason at cygnus dot com>
- Date: 05 May 2000 11:03:14 -0700
- Cc: gcc-patches at gcc dot gnu dot org
- References: <20000502155649.F540@sunsite.ms.mff.cuni.cz>
>>>>> Jakub Jelinek <jakub@redhat.com> writes:
> This patch fixes the C++ failure with static class data member of the same
> type as the containing class I posted today.
I think it's just papering over the real bug, which is that we don't layout
bar::baz properly when bar is complete. That's what
hack_incomplete_structures is supposed to be doing.
Your patch makes more sense for memcpying a pointer to a type that isn't
defined in the translation unit; but there, I think the right fix is to set
TYPE_ALIGN of incomplete types to something more reasonable rather than
change this one user of that information.
Jason