This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for some sign warnings
- To: jason at cygnus dot com
- Subject: Re: Patch for some sign warnings
- From: kenner at vlsi1 dot ultra dot nyu dot edu (Richard Kenner)
- Date: Thu, 4 May 00 17:43:22 EDT
- Cc: gcc-patches at gcc dot gnu dot org
Many remain; most of these are due to Kenner's Mar 25 change to make
GET_MODE_SIZE unsigned. IMO, this is a mistake, since other code
(notably, int_size_in_bytes and get_inner_reference) want to return -1
as an escape value for sizes. I think that GET_MODE_SIZE et al should
cast to HOST_WIDE_INT, but I don't feel like fixing right now all the
things that have already been changed to expect an unsigned...
I'm no longer sure what's right either, but I don't lke the "escape value"
usage in those functions. I'm inclined to eliminate that usage, but haven't
quite figured out how yet.