Re: AM33: enable inc4 for data registers...

[Jeffrey A Law <law at cygnus dot com>]

  In message <or3doc1tvs.fsf@zecarneiro.lsd.ic.unicamp.br>you write:
  > Here's an updated patch, to be checked in after the
  > am33-gcc-sp-reload.patch.  Ok to install?
What's different about it?  You just say it's an "updated" patch -- when
you submit a patch you're supposed to indicate to us what problem you
are trying to address and how your patch addresses the problem.  That is
standard procedure.  Without it people can not effectively review your
patch.

I think I know what you're trying to do here (same problem in a different
pattern).  But you should state that explicitly rather than making me guess.
I could guess wrong, which could then make my analysis of your patch faulty.

This patch is OK if and only if you've double checked the behavior of
"inc4" with your manual and it does indeed modify the condition codes
in some cases.  If that is the case, then please check on the behavior of
the simulator since I believe it will not modify the condition codes for
an "inc4" instruction.

jeff