This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: cpplib: Initial preparations for new lexer


On Sun, Apr 16, 2000 at 09:28:15AM +0900, Neil Booth wrote:
> This consists of a few changes I need to implement a new lexer.
> 
> It exports struct directive, renaming it struct cpp_directive, and
> redefines its origin field to be a flag field.  Two new flags are
> defined, regarding the syntax of the directive, and just they are
> exported.

This is not OK.  I don't want struct directive visible outside
cpplib.c if it can be avoided.  Even if it can't, it shouldn't be in
the public header.

Please explain why you need the entire structure and not just the flag
field, which could be handed back by a routine in cpplib.c.

zw

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]