This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix for off-by-one error in cpplib
- To: manfred dot h at gmx dot net
- Subject: Re: Fix for off-by-one error in cpplib
- From: Andreas Jaeger <aj at suse dot de>
- Date: 13 Mar 2000 17:48:03 +0100
- Cc: gcc-patches at gcc dot gnu dot org, Zack Weinberg <zack at wolery dot cumb dot org>
- References: <ho66uqdec8.fsf@maclaurin.suse.de> <38CD1AB8.1AFAC750@gmx.net>
>>>>> Manfred Hollstein writes:
Manfred> Andreas Jaeger wrote:
[...]
Manfred> Shouldn't this be
Manfred> + len = strlen (name) + 1;
Manfred> instead?
Definitly! Shame on me.
>> copy = (U_CHAR *) alloca (len);
>> memcpy (copy, name, len - 1);
>> copy[len] = '\0'; /* trim trailing quote */
>> private aj@arthur.rhein-neckar.de
Ok, here comes the corrected version.
Andreas
2000-03-13 Andreas Jaeger <aj@suse.de>,
Manfred Hollstein <manfred.h@gmx.net>
* cpplib.c (do_pragma_implementation): Fix off by one error.
Index: gcc/cpplib.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/cpplib.c,v
retrieving revision 1.131
diff -u -p -r1.131 cpplib.c
--- cpplib.c 2000/03/12 23:46:05 1.131
+++ cpplib.c 2000/03/13 16:47:01
@@ -1706,7 +1706,7 @@ do_pragma_implementation (pfile)
}
name = pfile->token_buffer + written + 1;
- len = strlen (name);
+ len = strlen (name) + 1;
copy = (U_CHAR *) alloca (len);
memcpy (copy, name, len - 1);
copy[len] = '\0'; /* trim trailing quote */
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.rhein-neckar.de