Re: Patch: Code Bloat g++

[Mark Mitchell <mark at codesourcery dot com>]

Martin --

  Thanks for the data.  Even though it seems that my patch killed most
of the .o file bloat that you got, you still get a little more.  So, I
don't see any reason not to install your patch.  Please consider it
approved.

  There's one buglet I found in the patch to dbxout_symbol_location:

	   else
	    dbxout_symbol_location (decl, subtype, "$imag", XEXP (home, 1));
    -      return;
    +      return 1;
	 }
       else
	 /* Address might be a MEM, when DECL is a variable-sized object.
	    Or it might be const0_rtx, meaning previous passes
	    want us to ignore this variable.  */
    -    return;
    +    return 1;

       /* Ok, start a symtab entry and output the variable name.  */
       FORCE_TEXT;

You should make the function as a whole return 1 as well, I think --
your patch causes dbxout_symbol_location to sometimes fall off the end
without returning a value.

  Thank you for submitting the patch, and for working with me as I
analyzed it.

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com