This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: goodbye, MD_CALL_PROTOTYPES
- To: Jeffrey A Law <law at cygnus dot com>
- Subject: Re: goodbye, MD_CALL_PROTOTYPES
- From: Zack Weinberg <zack at wolery dot cumb dot org>
- Date: Sat, 26 Feb 2000 16:16:00 -0800
- Cc: gcc-patches at gcc dot gnu dot org, ghazi at caip dot rutgers dot edu
- References: <20000224005726.G1098@wolery.cumb.org> <2514.951597169@upchuck>
On Sat, Feb 26, 2000 at 01:32:49PM -0700, Jeffrey A Law wrote:
>
> In message <20000224005726.G1098@wolery.cumb.org>you write:
> > Most .md files have been written as if that function took only two
> > arguments. Rather than change them all, I chose to change calls.c and
> > builtins.c so that it does. For the seven platforms that need the
> > extra info, we now have "xcall" and "xcall_value" insns. (Suggestions
> > for better names will be gladly accepted.)
>
> I would rather fix the md files -- IMHO, they're what's broken. Adding
> an additional pattern (xcall) is just avoiding the problem IMHO. It may be
> a pain, but let's fix the md files correctly.
The only way to fix the md files that I could find involved adding a
define_expand wrapper whose only purpose was to throw away the extra
args passed by calls.c, on top of whatever define_expand/define_insn
logic the port already used. Maybe you could suggest a better way?
My old patch is at http://gcc.gnu.org/ml/gcc-patches/2000-02/msg00123.html,
and has received no feedback whatsoever.
zw