This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Redundant (?) test in ix86_expand_{setcc,int_movcc}


Does it really make sense to repeat the test if it fails?

Index: gcc/ChangeLog
from  Alexandre Oliva  <oliva@lsd.ic.unicamp.br>
	* config/i386/i386.c (ix86_expand_setcc, ix86_expand_int_movcc):
	Remove redundant test.
	
Index: gcc/config/i386/i386.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/i386/i386.c,v
retrieving revision 1.118
diff -u -p -r1.118 i386.c
--- gcc/config/i386/i386.c	2000/01/04 14:44:03	1.118
+++ gcc/config/i386/i386.c	2000/01/08 20:33:10
@@ -4345,8 +4345,7 @@ ix86_expand_setcc (code, unordered, dest
 
   if (GET_MODE (dest) == QImode)
     type = 2;
-  else if (reg_overlap_mentioned_p (dest, ix86_compare_op0)
-	   || reg_overlap_mentioned_p (dest, ix86_compare_op0))
+  else if (reg_overlap_mentioned_p (dest, ix86_compare_op0))
     type = 1;
 
   if (type == 0)
@@ -4445,8 +4444,7 @@ ix86_expand_int_movcc (operands)
 	    }
 	  diff = ct - cf;
 
-	  if (reg_overlap_mentioned_p (out, ix86_compare_op0)
-	      || reg_overlap_mentioned_p (out, ix86_compare_op0))
+	  if (reg_overlap_mentioned_p (out, ix86_compare_op0))
 	    tmp = gen_reg_rtx (SImode);
 
 	  emit_insn (compare_seq);

-- 
Alexandre Oliva http://www.ic.unicamp.br/~oliva IC-Unicamp, Bra[sz]il
oliva@{lsd.ic.unicamp.br,guarana.{org,com}} aoliva@{acm,computer}.org
oliva@{gnu.org,kaffe.org,{egcs,sourceware}.cygnus.com,samba.org}
** I may forward mail about projects to mailing lists; please use them

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]