This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Committed: traditional stringification in include/symcat.h


I don't know why I didn't consider this change "obvious" before
submitting it some days ago -- I mean, SunOS 4.1.3 "cc" and "gcc
-traditional" agree.  Perhaps it was a question of whether having
this file around at all is ok, or if it should go away, but that's
unrelated, right?

No file in gcc currently seems to use it; I used it temporarily
for part of some gcc-internal-macro-as-function hacking.

Hmm.  I submitted the patch late last year, but I'm checking it
in now - so I guess (C) should be updated to 2000, not 1999.

So, commit it as "obvious"; there's no comment or logentry why "?"
should be more valid than "s", and I don't know of any reason.
It just looks like someone wasn't sure that it always worked
for K&R compilers, and forgot to write a FIXME: comment nearby.
Well, if "s" doesn't work, "?" will not work better, generally.

Enough about this silly thing.  I just wanted to bring it to closure.

Sat Jan  1 19:06:52 2000  Hans-Peter Nilsson  <hp@bitrange.com>

	* symcat.h (STRINGX) [!__STDC__ || ALMOST_STDC]: Change "?" to "s"
	to stringify argument s.

Index: symcat.h
===================================================================
RCS file: /cvs/gcc/egcs/include/symcat.h,v
retrieving revision 1.2
diff -p -c -r1.2 symcat.h
*** symcat.h	1999/09/04 15:08:49	1.2
--- symcat.h	2000/01/01 17:12:10
***************
*** 1,6 ****
  /* Symbol concatenation utilities.
  
!    Copyright (C) 1998, Free Software Foundation, Inc.
  
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
--- 1,6 ----
  /* Symbol concatenation utilities.
  
!    Copyright (C) 1998, 2000 Free Software Foundation, Inc.
  
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
***************
*** 28,34 ****
  #define CONCAT2(a,b)	 a/**/b
  #define CONCAT3(a,b,c)	 a/**/b/**/c
  #define CONCAT4(a,b,c,d) a/**/b/**/c/**/d
! #define STRINGX(s) "?"
  #endif
  
  #define XCONCAT2(a,b)     CONCAT2(a,b)
--- 28,34 ----
  #define CONCAT2(a,b)	 a/**/b
  #define CONCAT3(a,b,c)	 a/**/b/**/c
  #define CONCAT4(a,b,c,d) a/**/b/**/c/**/d
! #define STRINGX(s) "s"
  #endif
  
  #define XCONCAT2(a,b)     CONCAT2(a,b)

brgds, H-P




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]