This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Reformatting patch
- To: kenner at vlsi1 dot ultra dot nyu dot edu
- Subject: Re: Reformatting patch
- From: "David S. Miller" <davem at redhat dot com>
- Date: Sat, 18 Dec 1999 14:41:33 -0800
- CC: gcc-patches at gcc dot gnu dot org
- References: <9912182143.AA23177@vlsi1.ultra.nyu.edu>
Date: Sat, 18 Dec 99 16:43:59 EST
From: kenner@vlsi1.ultra.nyu.edu (Richard Kenner)
* reload.c (combine_reloads): Do nothing if no output reload
This is checked for early in combine_reloads, it is never changed
after that first test. Your change here is completely nonsensical.
The compiler would crash in earlier array references using
output_reload as the index which occur before your added test.
Next from flow.c:
-struct basic_block_def entry_exit_blocks[2] =
-{
- {
- NULL, /* head */
+struct basic_block_def entry_exit_blocks[2]
+= {{NULL, /* head */
I find this much less readable than the original construct.
Later,
David S. Miller
davem@redhat.com