This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: relative pathnames, take 2
- To: "Mark E." <snowball3 at bigfoot dot com>
- Subject: Re: Patch: relative pathnames, take 2
- From: Mumit Khan <khan at nanotech dot wisc dot edu>
- Date: Tue, 09 Nov 1999 10:22:51 -0600
- cc: gcc-patches at gcc dot gnu dot org, tromey at cygnus dot com
"Mark E." <snowball3@bigfoot.com> writes:
> Hi Tom,
>
> Code like this should use the conditional HAVE_DOS_STYLE_FILESYSTEM
> and IS_DIR_SEPARATOR like this:
I agree. However, we can always do another take after it's in the
tree. Tom, the "funny" patch in my ChangeLog is probably just a
holdover/workaround from the old days, and you were correct to ignore
it.
Mark, speaking HAVE_DOS_FILESYSTEM, there is a confusion between
HAVE_DOS_FILESYSTEM and HAVE_DOS_FILE_SYSTEM. The headers define
HAVE_DOS_BASED_FILE_SYSTEM, whereas gcc.c uses HAVE_DOS_BASED_FILESYSTEM.
The result is obvious. Gotta love these macros ;-)
I'd rather see gcc.c and i386/xm-djgpp.h changed to keep number of
modifications at a minimum. I came across while trying to debug a
few pathname related problems before releasing 2.95.2 binaries for
x86-win32.
./collect2.c:#ifdef HAVE_DOS_BASED_FILE_SYSTEM
./cppfiles.c:#if defined (HAVE_DOS_BASED_FILE_SYSTEM)
./cppinit.c:#if defined (HAVE_DOS_BASED_FILE_SYSTEM)
>> ./gcc.c:#ifdef HAVE_DOS_BASED_FILESYSTEM
>> ./gcc.c:#ifdef HAVE_DOS_BASED_FILESYSTEM
./config/i386/xm-cygwin.h:#define HAVE_DOS_BASED_FILE_SYSTEM
>> ./config/i386/xm-djgpp.h:#define HAVE_DOS_BASED_FILESYSTEM
./config/i386/xm-dos.h:#define HAVE_DOS_BASED_FILE_SYSTEM
./config/i386/xm-mingw32.h:#define HAVE_DOS_BASED_FILE_SYSTEM
./config/i386/xm-os2.h:#define HAVE_DOS_BASED_FILE_SYSTEM
./config/winnt/xm-winnt.h:#define HAVE_DOS_BASED_FILE_SYSTEM
Regards,
Mumit