This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: A patch for reg-stack.c
- To: "H . J . Lu" <hjl at valinux dot com>
- Subject: Re: A patch for reg-stack.c
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Thu, 14 Oct 1999 03:14:19 -0600
- cc: egcs-patches at egcs dot cygnus dot com, egcs-bugs at egcs dot cygnus dot com, stevenj at hunsmac dot mit dot edu
- Reply-To: law at cygnus dot com
In message <19991013140038.A21784@valinux.com>you write:
> I believe this patch should fix
>
> http://egcs.cygnus.com/ml/gcc-bugs/1999-10/msg00011.html
>
> This bug only shows up if flag_pcc_struct_return is 1, which is the
> default for Linux since the SVR4 ABI we are using requires the
> structure/union be returned in memory regardless the size of
> structure/union. I hope it will be fixed in gcc 2.95.2.
As usual, you provided no details about why your patch fixes the bug. At the
*very least* you should have indicated which function was being mis-compiled.
But in your usual lame fashion you failed to provide that (or any other)
critical piece of information
I will not review this patch. Sorry. You have to learn to play by the
same rules as everyone else.
jeff