This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix PPC eabi constructor order
- To: jlarmour at cygnus dot co dot uk (Jonathan Larmour)
- Subject: Re: Fix PPC eabi constructor order
- From: Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>
- Date: Tue, 12 Oct 1999 15:14:55 +0200
- Cc: gcc-patches at gcc dot gnu dot org
- References: <37AF2370.F1A672D6@cygnus.co.uk>
At 15:00 12.10.99 , Jonathan Larmour wrote:
>Ping. It may still be relevant for gcc-2.95.2.
>
>In article <37AF2370.F1A672D6@cygnus.co.uk> I write:
> >
> >powerpc-eabi was running through the constructors in the wrong order. This
> >patch fixes that. I thought it had already been applied by someone else, but
> >it turns out it wasn't :-/.
> >
> >I'm not affected by this bug myself, so I personally don't care, but it
> >should probably go on the branch anyway since it's a bug fix.
> >
> >Jifl
>
>Wed Jul 7 14:16:02 1999 Jonathan Larmour <jlarmour@cygnus.co.uk>
>
> * config/rs6000/eabi-ctors.c (__do_global_ctors): Run through
> __CTOR_LIST__ in opposite order, which is the correct order for
> sorted
> constructors
> * (__do_global_dtors): similarly for __DTOR_LIST__
Since you seem to know something about this stuff, maybe you can tell me if
this patch for binutils is correct and needed? It just removes a small
difference between elf.sc and elfppc.sc:
Index: ld/scripttempl/elfppc.sc
===================================================================
RCS file: /cvs/binutils/binutils/ld/scripttempl/elfppc.sc,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 elfppc.sc
--- elfppc.sc 1999/05/03 07:29:08 1.1.1.1
+++ elfppc.sc 1999/10/12 13:09:24
@@ -170,7 +170,7 @@ SECTIONS
*(.data)
${RELOCATING+*(.data.*)}
${RELOCATING+*(.gnu.linkonce.d*)}
- ${CONSTRUCTING+CONSTRUCTORS}
+ ${CONSTRUCTING+SORT(CONSTRUCTORS)}
}
.data1 ${RELOCATING-0} : { *(.data1) }
${RELOCATING+${OTHER_READWRITE_SECTIONS}}
Thanks,
Franz.