This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Genrecog bugfix version 2
- To: Graham <grahams at rcp dot co dot uk>
- Subject: Re: Genrecog bugfix version 2
- From: Horst von Brand <vonbrand at sleipnir dot valparaiso dot cl>
- Date: Sun, 26 Sep 1999 00:00:40 -0400
- cc: gcc-patches at gcc dot gnu dot org
Graham <grahams@rcp.co.uk> said:
> There is a typo in this patch the swap needs to use ',' and not ';'
> Richard Henderson wrote:
>
> > + /* If the d2->position was lexically lower, swap. */
> > + if (cmp > 0)
> > + p1 = d1; d1 = d2; d2 = p1;
> > +
What is wrong with plain, simple, down-to-earth:
+ /* If the d2->position was lexically lower, swap. */
+ if (cmp > 0)
+ {p1 = d1; d1 = d2; d2 = p1;}
+
Putting ','s in there will just confuse the unwary...
--
Horst von Brand vonbrand@sleipnir.valparaiso.cl
Casilla 9G, Viņa del Mar, Chile +56 32 672616