This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: C++ PATCH: Reimplementation of error.c


>>>>> "Nathan" == Nathan Sidwell <nathan@acm.org> writes:

    Nathan> Unless I've missed how to get plain `X', I don't think the
    Nathan> changes to IDENTIFIER_TEMPLATE can be made orthogonally to
    Nathan> the error.c patch.

Yes; the way in which we use name-lookup to handle problems that would
be more cleanly handled in other ways is definitely obscure.  I
suggest you just replace mangle_class_name_for_template with some
appropriate call to error.c to get the same name that was there
before; or, for that matter, just leave mangle_class_name_for_template
alone.

In other words, let's make life simpler by doing one thing at a time.
Your patches to improve error message formatting are fine; let's leave
the issue of commonizing the printing code in pt.c for another day.
That should be workable, yes?

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]