This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: A new libobjc patch
- To: ovidiu at cup dot hp dot com (Ovidiu Predescu)
- Subject: Re: A new libobjc patch
- From: hjl at varesearch dot com (H.J. Lu)
- Date: Sun, 5 Sep 1999 07:21:11 -0700 (PDT)
- Cc: egcs-patches at egcs dot cygnus dot com
>
> Hi HJ,
>
> On Thu, 12 Aug 1999 09:00:21 -0700 (PDT), hjl@varesearch.com (H.J. Lu) wrote:
>
> > This is a new libobjc patch to replace my previous libobjc patch. I
> > tested it on Linux/x86/glibc 2, Linux/x86/libc 5, Solaris 7/x86 and
> > Solaris 7/Sparc. It seems to work ok for me.
>
> I looked on your patch, but it seems like it is disabling thread-support for
> some platforms: Irix, Dec/OSF, NeXTSTEP/OPENSTEP/Rhapsody, OS/2, Windows and
> maybe others. You're replacing the appropriate thr-platform file with a generic
> thr-objc file, but support for the above platforms doesn't seem to be there in
> libgcc. As I don't have access to the above systems to add the necessary
> support and test the changes, I cannot apply your patch.
>
I don't have access to those system either. However, I did see these
in libobjc/configure.in:
----
# Determine the name of the GCC thread file.
AC_CACHE_CHECK([for thread file],objc_cv_thread_file,
[if test -f "$r"/gcc/Makefile
then
objc_cv_thread_file=`grep \^GCC_THREAD_FILE "$r"/gcc/Makefile | awk -F= '{
print $2 }'`
else
AC_MSG_ERROR([not found])
fi])
OBJC_THREAD_FILE=$objc_cv_thread_file
AC_SUBST(OBJC_THREAD_FILE)
----
I assume you are familiar with libobjc. Can you tell me what happens on
those systems you mentioned when you enable thread on them?
I may be wrong. As far as I can tell,
1. thr-single.c is used for libobjc on systems where thread is not
supported in libgcc.a because GCC_THREAD_FILE in gcc/Makefile is
"single".
2. "make check" fails in libobjc on systems where thread is supported
in libgcc.a because -lthread is missing.
--
H.J. Lu (hjl@gnu.org)