Re: PATCH: Fix 2 PPC/SYSV varargs problems

[Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>]

At 13:35 02.07.99 , Jeffrey A Law wrote:

>   In message <4.2.0.58.19990701111404.03ca7250@mail.lauterbach.com>you write:
>   > I don't think changing the abi behaviour for a dot release is a good 
> idea.
>If it is fixing a bug in the compiler (ie we did not properly implement
>the published ABI), then it is OK IMHO.
>
>I was also under the impression this only effected cases where we passed
>more than 7 floats to a varargs function, which hasn't ever worked anyway.

It works with the egcs-1.1.2 RPM's I built for R5 :-). The gcc-2.95 RPM's I 
will build will have a fixed version of Richard's patch then.


>   > Personally I would vote for now, even if that means I probably have 
> to deal
>   > with some bug reports due to the ABI fix.
>   > Otherwise, include at least my version of the fix for 2.95, as it 
> does only
>   > fix the varargs bugs and does not change the ABI.
>I'm not planning on either patch.  We've had this bug for years, we can live
>with it a little longer.  Striving for perfection is good; rRequiring it is
>bad.
>
>Compiler development is an iterative process.  I'm satisfied with the progress
>we have made on the ppc for this release.  Is it perfect?  No, is it a
>significant improvement over previous releases, absolutely.  Will we address
>some of the remaining open issues for the next release?  I certainly hope so.

Well, what I'm a little bit annoyed about in this release cycle, is that I 
really invested a lot of time testing and reporting bugs and presenting 
patches as soon as the branch had happened, to make sure the fixes all meet 
the schedule. But somehow this didn't work :-(.

But I assume that's life :-). I totally agree with you that gcc-2.95 will 
again be a big step forward for PPC.

Big thanks to the whole egcs/gcc team for your support and help!!! (no irony!)

Franz.