Re: i387 patterns cleanup

[Jan Hubicka <hubicka at horac dot ta dot jcu dot cz>]

On Sun, Apr 11, 1999 at 03:11:53PM -0700, Richard Henderson wrote:
> On Sun, Apr 11, 1999 at 02:43:47PM +0200, Jan Hubicka wrote:
> > > Shouldn't you be deleting the old float_extend patterns?
> > The float extend patterns are still used for bare extension (I didn't
> > touched the mov patterns yet.)
> 
> You misunderstand.  We had 
> 
>   [(set (cc0)
>         (match_operator 2 "VOIDmode_compare_op"
>                         [(match_operand:DF 0 "nonimmediate_operand" "f,fm")
>                          (match_operand:DF 1 "nonimmediate_operand" "fm,f")]))
> ...
>   [(set (cc0)
>         (match_operator 2 "VOIDmode_compare_op"
>                         [(match_operand:DF 0 "register_operand" "f")
>                          (float_extend:DF
>                           (match_operand:SF 1 "nonimmediate_operand" "fm"))]))
> ...
>   [(set (cc0)
>         (match_operator 2 "VOIDmode_compare_op"
>                         [(float_extend:DF
>                           (match_operand:SF 0 "nonimmediate_operand" "fm"))
>                          (match_operand:DF 1 "register_operand" "f")]))
> 
> You converted all three to use the new extend matching predicate,
> so we wind up with three copies of the same pattern.
> 
> Perhaps I was merely misreading the diffs, but I didn't think so.
I think I missreaded it. I have remove such extend patterns.
Purpose why there is not significantly less patterns is that XF patterns
still needs copies. This is because XF parameters can't be rad from
memory, while others can. So I have to make four copies allowing memory
in both parameters (and requiring the extend from DF or SF), in one
parameter and in none.

Maybe I've forgot to remove some cases, but while creating the patch
I always first removed the extension patterns and then created the
XF copies from the scratch, so I hope didn't missed them.

ALso note that there is forgotten redundant if checking mode of insn
in new version of my patch...

Honza
> 
> 
> r~

-- 
------------------------------------------------------------------------------
                   Have you browsed my www pages? Look at:
                       http://www.paru.cas.cz/~hubicka
      Koules-the game for Svgalib,X11 and OS/2,  Xonix-the game for X11
      czech documentation for linux index, original 2D computer art and
              funny 100 years old photos and articles are there!