This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Proposed PATCH: cplus-dem test suite
- To: tromey at cygnus dot com
- Subject: Re: Proposed PATCH: cplus-dem test suite
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Fri, 02 Apr 1999 11:53:57 -0700
- cc: Egcs Patch List <egcs-patches at cygnus dot com>
- Reply-To: law at cygnus dot com
In message <87zp4s6v2q.fsf@cygnus.com>you write:
> As it turns out, my earlier patch to cplus-dem.c had a bug, which was
> discovered by Jim Blandy during gdb testing. I looked, and it turns
> out that gdb has quite a number of demangling tests. I think these
> tests should be part of libiberty, so that it is as easy as possible
> to check changes to the demangler. I for one had no idea until today
> that such a test suite even existed.
>
> To this end, I propose the appended patch. It adds some new files to
> libiberty, and arranges for `make check' to run the test suite (but
> only when libiberty is configured as a native library; the test suite
> is disabled for the target library case). The test suite has 615
> tests, including a test for the bug I was originally trying to fix.
>
> Yes, I do have a patch to fix the bug I introduced. I will submit it
> separately. It turns out that the test suite also reveals other bugs
> in cplus-dem; I have a fix (from somebody else) for these which I'll
> send.
>
> 1999-04-01 Tom Tromey <tromey@cygnus.com>
>
> * Makefile.in (check): Depend on @CHECK@.
> (check-cplus-dem): New target.
> (test-filter): New target.
> (mostlyclean): Remove test-us.c and test-filter.
> * regress-demangle: New file.
> * demangle-expected: New file.
> * configure: Rebuilt.
> * configure.in (CHECK): New subst.
>
> I've left the `configure' diffs out of the appended patch.
> New files are diffs against /dev/null.
Looks good to me! Please install it.
Thanks!
jeff