This is the mail archive of the
mailing list for the GCC project.
Re: Patch to remove re-assert warnings on powerpc-*-linux-*
- To: law at cygnus dot com, drow at false dot org
- Subject: Re: Patch to remove re-assert warnings on powerpc-*-linux-*
- From: Zack Weinberg <zack at rabi dot columbia dot edu>
- Date: Mon, 29 Mar 1999 13:03:05 -0500
- cc: egcs-patches at egcs dot cygnus dot com
On Mon, 29 Mar 1999 00:11:34 -0700, Jeffrey A Law wrote:
> > > >On Sat, Mar 27, 1999 at 11:03:50AM -0500, Zack Weinberg wrote:
> > > >> I think you can safely delete all references to CPP_OS_LINUX_SPEC.
> > > >> CPP_PREDEFINES is a much better place to do this sort of thing, if
> > > >> only because it gets the test for defining bare `unix' right.
>I don't think this is correct.
>Look at how CPP_OS_LINUX_SPEC is used in CPP_SPEC.
>Specifically, it supposed to be used to provide linux defines and assertions
>when the -mcall-linux flag is given to the compiler.
>If you remove stuff from CPP_OS_LINUX_SPEC you will break that functionality.
>This goes for both -D arguments and assertions.
I'm somewhat surprised that -mcall-linux implies -Dlinux (I thought
-mcall-* only affected function calling conventions) but OK.
Dan, two things about your patch: Can't we get rid of the redefinition
of CPP_PREDEFINES in rs6k/linux.h now? And as long as you're there,
you should go through and fix the conditional for defining bare macros
in all the CPP_OS_*_SPEC defines.