This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch to remove re-assert warnings on powerpc-*-linux-*


On Sat, Mar 27, 1999 at 03:13:28PM -0500, Zack Weinberg wrote:
> On Sat, 27 Mar 1999 15:05:49 -0500, Daniel Jacobowitz wrote:
> >On Sat, Mar 27, 1999 at 11:03:50AM -0500, Zack Weinberg wrote:
> >> I think you can safely delete all references to CPP_OS_LINUX_SPEC.
> >> CPP_PREDEFINES is a much better place to do this sort of thing, if
> >> only because it gets the test for defining bare `unix' right.
> >
> >I don't follow.  It doesn't HAVE a test for -Dunix; CPP_PREDEFINES
> >comes from linux.h, and defines -Dunix unconditionally.
> 
> Yup.  The test happens in gcc.c, in the processing of the %p and %P spec
> macros.  Look at what the specs in default_compilers do when invoking cpp.

Ahah, I think I see what you mean.  As it stands now, though, -Dunix
gets defined irregardless of -ansi; this does not happen on x86,  And I
can not see it coming from CPP_OS_LINUX_SPEC, which explicitly marks
them as %{!ansi}.  I think that perhaps I need to dig a little deeper
to figure out what the powerpc predefines are supposed to be; they seem
to have gotten out of sync with other architectures at some point.

In the mean time, my patch is correct for at least the -Asystem()
stuff, which is what I most wanted to accomplish.

Dan

/--------------------------------\  /--------------------------------\
|       Daniel Jacobowitz        |__|     CMU, CS class of 2002      |
|   Debian GNU/Linux Developer    __   Part-Time Systems Programmer  |
|         dan@debian.org         |  |        drow@cs.cmu.edu         |
\--------------------------------/  \--------------------------------/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]