Re: PATCH: more read_integral_parameter'ization

[Jeffrey A Law <law at hurl dot cygnus dot com>]

  In message <199902252219.XAA19303@mururoa.inria.fr>you write:
  > Thu Feb 25 21:49:55 1999  Theodore Papadopoulo  <Theodore.Papadopoulo@sophi
  > a.inria.fr>
  > 
  > 	* toplev.h (read_integral_parameter): Constify.
  > 	* toplev.c (read_integral_parameter): Constify. Better control of
  >	error messages.
  > 	(main): Use read_integral_parameter.
Thanks.  Minor comments to follow.


  > ! 	      const int optimize_val = read_integral_parameter(p, p - 2, -1);
Always put a space between the function name and the open paren.

  > ! 		  const int id_clash_val = read_integral_parameter(p + 9, p - 2
  > , -1);
In addition to missing the space between the name and open paren, the line is
also greater than 80 characters and should be split.  There's a couple ways.

One is to split after the commas for the arguments.  Another is to split
before the equal sign.

  > ! 		      level = read_integral_parameter(p, 0, max_debug_level + 1
  > );
Likewise.

I fixed these minor problems and installed your patch.

Thanks!

jeff

ps.  This is the limit of what I can accept without a copyright assignment.
If you plan on submitting further changes you'll need to fill out legal
paperwork.  See http://egcs.cygnus.com/contribute.html