This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: A warning patch for config/sparc/*



  In message <199903021617.LAA08404@caip.rutgers.edu>you write:
  > 	This patch fixes warnings arising from files in config/sparc/*.
  > Okay to install?
  > 
  > 		--Kaveh
  > 
  > 
  > 
  > Tue Mar  2 11:00:19 1999  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
  > 
  > 	* gmon-sol2.c: Include config.h and system.h.  Don't redundantly
  > 	include system header files.
  > 	(sccsid): Mark with ATTRIBUTE_UNUSED.
  > 	(moncontrol, monstartup, _mcleanup, internal_mcount): Prototype.
  > 	(_mcleanup): Add the `const' keyword to a char*.
  > 	(internal_mcount): Explicitly define the return type of `etext'.
  > 	Cast `etext' to char* when calling `monstartup'.
This reminds me of a long-standing bug report.

In the effort to remove warnings, we made moncontrol static in gmon-sol2.c
which may not be a good idea -- I think that's supposed to be an externally
visible function so that the user's code can enable/disable profiling.  We've
had at least one bug report on this.

Thoughts?

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]