This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Java warning patches part 2/2


>>>>> "Kaveh" == Kaveh R Ghazi <ghazi@caip.rutgers.edu> writes:

    >> From: Per Bothner <bothner@cygnus.com>
    >> 
    >> + uint16 minor_version ATTRIBUTE_UNUSED = JCF_readu2 (jcf); +
    >> uint16 major_version ATTRIBUTE_UNUSED = JCF_readu2 (jcf);
    >> 
    >> I think I prefer this style:
    >> 
    >> (void) JCF_readu2 (jcf); /* minor_version */ (void) JCF_readu2
    >> (jcf); /* major_version */

I like this style, too.  But, it's directly against the GNU Coding
Standards:

  Please don't insert any casts to `void'.

-- 
Mark Mitchell 			mark@markmitchell.com
Mark Mitchell Consulting	http://www.markmitchell.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]