This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: A constify patch part 7/7


 > From: Jeffrey A Law <law@hurl.cygnus.com>
 >   >     This is a constify patch, part 1/7.  Okay to install?
 > Fine.
 > jeff
 > 
 > From: Jeffrey A Law <law@hurl.cygnus.com>
 >   >     This is a constify patch, part 2/7.  Okay to install?
 > Fine.  Thanks,
 > jeff
 > 
 > From: Jeffrey A Law <law@hurl.cygnus.com>
 >   >     This is a constify patch, part 3/7.  Okay to install?
 > Fine.  Thanks!
 > jeff
 > 
 > From: Jeffrey A Law <law@hurl.cygnus.com>
 >   >     This is a constify patch, part 4/7.  Okay to install?
 > Fine.  Thanks!
 > jeff
 > 
 > From: Jeffrey A Law <law@hurl.cygnus.com>
 >   >     This is a constify patch, part 5/7.  Okay to install?
 > Why are we including basic-block in toplev.c?  It's probably OK, but I'd
 > like to know why we're making that change.
 > The other parts of this patch are OK and you can install them.
 > jeff
 > 
 > From: Jeffrey A Law <law@hurl.cygnus.com>
 >   >     This is a constify patch, part 6/7.  Okay to install?
 > Presumably moving the insn-config.h was necessary to get some
 > target dependent macro defined earlier?  If so, you should probably
 > note that as a comment in the code itself.  ie something like
 > /* insn-config.h must come before foo.h to get FROB properly
 > defined for foo.h */
 > Or something along those lines.
 > With such a comment this patch is OK.
 > Thanks,
 > jeff
 > 
 > From: Jeffrey A Law <law@hurl.cygnus.com>
 >   >     This is a constify patch, part 7/7.  Okay to install?
 > This is fine.  Thanks.
 > I presume you've done a bootstrap on the set as a whole :-)
 > jeff

	Yes, I always do so. :-)  Irix6 in this case.

	Thanks for reviewing all of these patches.  I added the
comment you requested and installed everything except basic-block.h in
toplev.c (from part 5).  I explained that one in:

	http://egcs.cygnus.com/ml/egcs-patches/1999-03/msg00129.html

and I'm awaiting approval of it standalone before installing it.



Thu Mar  4 20:48:31 1999  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>

	* Makefile.in (toplev.o): Depend on $(BASIC_BLOCK_H).

	* toplev.c: Include basic-block.h.

diff -rup orig/egcs-CVS19990303/gcc/Makefile.in egcs-CVS19990303/gcc/Makefile.in
--- orig/egcs-CVS19990303/gcc/Makefile.in	Tue Mar  2 16:29:34 1999
+++ egcs-CVS19990303/gcc/Makefile.in	Thu Mar  4 14:48:51 1999
@@ -1435,7 +1435,7 @@ fold-const.o : fold-const.c $(CONFIG_H) 
 toplev.o : toplev.c $(CONFIG_H) system.h $(TREE_H) $(RTL_H) \
    flags.h input.h insn-attr.h xcoffout.h defaults.h output.h \
    insn-codes.h insn-config.h intl.h $(RECOG_H) Makefile toplev.h dwarfout.h \
-   dwarf2out.h sdbout.h dbxout.h $(EXPR_H) \
+   dwarf2out.h sdbout.h dbxout.h $(EXPR_H) $(BASIC_BLOCK_H) \
    $(lang_options_files)
 	$(CC) $(ALL_CFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $(MAYBE_USE_COLLECT2) \
 	  -DTARGET_NAME=\"$(target_alias)\" \
diff -rup orig/egcs-CVS19990303/gcc/toplev.c egcs-CVS19990303/gcc/toplev.c
--- orig/egcs-CVS19990303/gcc/toplev.c	Mon Mar  1 17:06:02 1999
+++ egcs-CVS19990303/gcc/toplev.c	Thu Mar  4 14:47:55 1999
@@ -51,6 +51,7 @@ Boston, MA 02111-1307, USA.  */
 #include "except.h"
 #include "toplev.h"
 #include "expr.h"
+#include "basic-block.h"
 #include "intl.h"
 
 #ifdef DWARF_DEBUGGING_INFO


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]