This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: A constify patch part 6/7



  In message <199903050223.VAA24424@caip.rutgers.edu>you write:
  > 	This is a constify patch, part 6/7.  Okay to install?
  > 
  > 		--Kaveh
  > 
  > 
  > Thu Mar  4 20:48:31 1999  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
  > 
  > 	* optabs.c: Include insn-config.h earlier.
  > 	(init_libfuncs, init_integral_libfuncs, init_floating_libfuncs):
  >  	Qualify a char* with the `const' keyword.
Presumably moving the insn-config.h was necessary to get some target dependent
macro defined earlier?  If so, you should probably note that as a comment in
the code itself.  ie something like

/* insn-config.h must come before foo.h to get FROB properly defined for foo.h */  

Or something along those lines.

With such a comment this patch is OK.

Thanks,
jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]