This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Openbsd configuration, i386
- To: Marc Espie <espie at tetto dot liafa dot jussieu dot fr>
- Subject: Re: Openbsd configuration, i386
- From: Jeffrey A Law <law at hurl dot cygnus dot com>
- Date: Wed, 17 Feb 1999 00:51:24 -0700
- cc: egcs-patches at egcs dot cygnus dot com
- Reply-To: law at cygnus dot com
In message <19990216184522.A16335@tetto.liafa.jussieu.fr>you write:
>
> --Kj7319i9nmIyA2yE
> Content-Type: text/plain; charset=us-ascii
>
> Here are the configuration files for i386
>
> Tue Feb 16 18:43:09 CET 1999 Marc Espie <espie@cvs.openbsd.org>
> * config/i386/openbsd.h: new file, originally from netbsd
> * config/i386/xm-openbsd.h: new file
A few more comments.
Kill the RCS keywords. I don't want to have to edit all of your submissions
to kill the keyword expansions.
You need a copyright header on each new file with a proper date.
Kill the "------------" stuff in the comments, no other ports have such
braindamage. A consistent comment style with the rest of the compiler is
important.
Comments should generally be complete sentences with proper punctuation
and capitolization. The comment ends with a period, two spaces and the
close comment chars.
> if ((LOG)!=0) \
> if ((MAX_SKIP)==0) fprintf ((FILE), "\t.p2align %d\n", (LOG));
> \
> else fprintf ((FILE), "\t.p2align %d,,%d\n", (LOG), (MAX_SKIP));
> \
> } while (0)
> #endif
Space around the != and the ==. I suspect you caught this goof from other
files. I fixed a handful of these to avoid other folks making the same
mistake.
I actually prefer a patch rather than raw files encapsulated in mime stuff.
They're easier to deal with, particularly when dealing with lots of new
files.
jeff