This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Followup on previous inheritance fix



  In message <Pine.GSO.4.02A.9810261307040.29793-100000@colt.informatik.rwth-aa
chen.de>you write:
  > The second problem with using reg_reloaded_dead in that condition is that
  > it seems wrong.  Consider the situation where we store hard reg A from
  > pseudo B, and B dies.  Then, in the following insn, reg_reloaded_dead is 1
  > for A, so the condition above does not apply.  This means the compiler
  > could try to use A for an in-out reload in the circumstances described
  > above, _even if there is a store to another pseudo that has hard reg A_ in
  > the same insn.
  > 
  > I believe that we should not test reg_reloaded_dead here, just avoid this
  > optimization whenever reg_used_by_pseudo is nonzero.
But shouldn't this case have been kicked out as invalid via the call to
reload_reg_free_for_value_p earlier in that same function?

The other changes make sense and I'll go ahead and install them.

It would be wise in the future to include testcases with your bugfixes so
that we can look at them under the debugger too to help understand what is
happening.

jeff



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]