This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: A few warning patches ...



  In message <19981026185421.B25151@dot.cygnus.com>you write:
  > On Sun, Oct 25, 1998 at 12:57:36PM -0500, Kaveh R. Ghazi wrote:
  > > 	(allocate_reg_info): Move variable `i' into the scope where it is
  > > 	used.  Change its type to `size_t'.
  > 
  > FYI, the argument to allocate_reg_info, num_regs, and thence almost
  > all of the size_t variables in that function should be signed.
  > 
  > Look at the first test:
  > 
  >   /* Free up all storage allocated */
  >   if (num_regs < 0)
  >     {
  > 
  > which cannot be true if num_regs is unsigned.  And it does seem like
  > we'd at some point like to free up the reg info.  ;-)
This has come up before.  But we never heard back from Michael.

Michael, as it stands, we never call allocate_reg_info with a negate argument
to free up the storage.  WHen did you envision that we'd free up the storage?
Once per compilation unit?  After each function? when?

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]