This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: A few warning patches ...
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>, egcs-patches at cygnus dot com
- Subject: Re: A few warning patches ...
- From: Richard Henderson <rth at cygnus dot com>
- Date: Mon, 26 Oct 1998 18:54:21 -0800
- References: <199810251757.MAA03907@caip.rutgers.edu>
- Reply-To: Richard Henderson <rth at cygnus dot com>
On Sun, Oct 25, 1998 at 12:57:36PM -0500, Kaveh R. Ghazi wrote:
> (allocate_reg_info): Move variable `i' into the scope where it is
> used. Change its type to `size_t'.
FYI, the argument to allocate_reg_info, num_regs, and thence almost
all of the size_t variables in that function should be signed.
Look at the first test:
/* Free up all storage allocated */
if (num_regs < 0)
{
which cannot be true if num_regs is unsigned. And it does seem like
we'd at some point like to free up the reg info. ;-)
r~