This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Creating a prettier flow graph


On Mon, Oct 26, 1998 at 02:22:39PM +0100, Bernd Schmidt wrote:
> struct basic_block **bblock;
> 
> Then, "s/basic_block_head[$1]/bblock[$1]->head/".
> 
> I think too much of the compiler is written in capital letters ;)

Mmm.  Actually, I used even more capital letters.  In my patch if you
wanted to avoid BLOCK_HEAD, you would write BASIC_BLOCK(b)->head.  I
used the varray bits so that the array would have bounds checking
enabled with --enable-checking. 

However, in new code I most often wrote things like

	for (i = 0; i < n_basic_blocks; ++i)
	  {
	    basic_block b = BASIC_BLOCK (i);
	    edge e;

	    for (e = b->succ; e ; e = e->succ_next)
	      ...
	  }

Which does not have an overabundance of capital letters.  ;-)


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]